Skip to content

Conversation

@Laetitia1402
Copy link

No description provided.

@amorison
Copy link
Member

Thank you for this PR. The change itself looks good. Could you please update the docstring so that the new option is documented? Copying the bit about the field argument in the docstring of plot_scalar would work well.

Also, this is more minor but could you fix the indentation and the trailing space that flake8 warns about? You can look at the results from the check, but it might be more convenient for you to run it locally with tox -e flake8 (tox can be installed via pip). Let me know if you run into troubles, I can fix the formatting when merging if you prefer.

@Laetitia1402
Copy link
Author

Laetitia1402 commented Jan 3, 2022 via email

@amorison
Copy link
Member

amorison commented Jan 3, 2022

Thanks for the corrections.

The type error pointed out by mypy in the CI is unrelated to those changes, and CI needs to be fixed anyway (see #83). Since the changes in this PR are simple, I'll merge it anyway.

@amorison amorison merged commit db0d34e into StagPython:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants