Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jun 26, 2025

Why I'm doing:

I want to get how expensive a query is in terms of network usage quickly from the DD log instead of from the query profile. The enhancement can allow us to find out which queries that take the most network resources easily from the DD log. Otherwise, we can only get the most network usage queries by checking out all the query profiles individually.

What I'm doing:

I tried to add the transmitted bytes into the FE AuditLog. I open the PR for review ignoring the test coverage CI since I cannot figure out how to add unit tests for the AuditLog.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
    • 3.2
    • 3.1

This is an automatic backport of pull request #58346 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Jun 26, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Jun 26, 2025

Cherry-pick of 4b74e7d has failed:

On branch mergify/bp/branch-3.5/pr-58346
Your branch is up to date with 'origin/branch-3.5'.

You are currently cherry-picking commit 4b74e7d831.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/exec/pipeline/exchange/exchange_sink_operator.cpp
	modified:   be/src/exec/pipeline/exchange/exchange_sink_operator.h
	modified:   be/src/exec/pipeline/exchange/sink_buffer.cpp
	modified:   be/src/exec/pipeline/exchange/sink_buffer.h
	modified:   be/src/exec/pipeline/query_context.cpp
	modified:   be/src/exec/pipeline/query_context.h
	modified:   be/src/runtime/query_statistics.cpp
	modified:   be/src/runtime/query_statistics.h
	modified:   fe/fe-core/src/main/java/com/starrocks/common/util/AuditStatisticsUtil.java
	modified:   fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java
	modified:   gensrc/proto/data.proto
	modified:   gensrc/thrift/FrontendService.thrift

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/plugin/AuditEvent.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 26, 2025 05:24
@mergify mergify bot closed this Jun 26, 2025
auto-merge was automatically disabled June 26, 2025 05:24

Pull request was closed

@mergify
Copy link
Contributor Author

mergify bot commented Jun 26, 2025

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

Signed-off-by: Siqi Ling <s.ling@celonis.com>
(cherry picked from commit 4b74e7d)
@murphyatwork murphyatwork reopened this Jun 26, 2025
@murphyatwork murphyatwork force-pushed the mergify/bp/branch-3.5/pr-58346 branch from 421905f to dac5658 Compare June 26, 2025 05:29
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 26, 2025 05:29
@sonarqubecloud
Copy link

@wanpengfei-git wanpengfei-git merged commit 7a4e35a into branch-3.5 Jun 26, 2025
33 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.5/pr-58346 branch June 26, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants