Skip to content

fix: include zero-rated vat transactions in vat return #34

Merged
dvdl16 merged 2 commits into
version-15from
fix/zero-rated
Sep 23, 2025
Merged

fix: include zero-rated vat transactions in vat return #34
dvdl16 merged 2 commits into
version-15from
fix/zero-rated

Conversation

@dvdl16
Copy link
Copy Markdown
Collaborator

@dvdl16 dvdl16 commented Sep 23, 2025

Description

  • fix: include zero-rated vat transactions in vat return

Fixes #33

Type of change

  • 🟢 Bug fix (change which fixes an issue)
  • ⚪ New feature (change which adds functionality)
  • ⚪ Breaking change (fix or feature that would cause existing functionality to not work as expected)

Tests

  • Unit Tests have been updated or added, as required
  • UI Tests have been updated or added, as required

Checklist:

  • My code follows Naming Guidelines (DocType, Field and Variable naming)
  • No Form changes / My code follows the Form Design Guidelines
  • My code follows the Coding Standards of this project
  • My code follows the Code Security Guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas / No comments necessary
  • I have made corresponding additions/changes to the documentation
  • All business logic and validations are on the server-side / No business logic or validation changes
  • No patches are necessary / Migration Patches have been added to the correct subdirectory of /patches and patches.txt have been updated

User Experience:

N/A

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.16%. Comparing base (7b63994) to head (0c7ea7e).

Files with missing lines Patch % Lines
...e/value_added_tax_return/value_added_tax_return.py 46.15% 7 Missing ⚠️
csf_za/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           version-15      #34      +/-   ##
==============================================
- Coverage       40.30%   40.16%   -0.14%     
==============================================
  Files              10       10              
  Lines             464      473       +9     
==============================================
+ Hits              187      190       +3     
- Misses            277      283       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dvdl16 dvdl16 merged commit 79c029f into version-15 Sep 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Invoices with Tax Template linked to 'Zero Rated' are not taken into account

2 participants