Disable soft deletion of AttributeOverride#449
Merged
Starosdev merged 2 commits intoStarosdev:masterfrom Apr 9, 2026
Merged
Conversation
Owner
|
No intentional reason for soft-delete. The original model used gorm.Model which bundles DeletedAt automatically. It was just the GORM default, not a deliberate design choice. Removing it is the right fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Soft deletion of AttributeOverride leaves the record in database. New records can't be added because of the unique constraint.
The issue can be fixed either by changing deletion code to explicitly hard-delete, or by removing DeletedAt field, which disables implicit soft delete in GORM.
I don't see any reasons for soft deletion, therefore this PR removes DeletedAt field.
Type of Change
Related Issues
Fixes #447
Changes Made
Testing
None of the existing tests validates database insert/delete/constraint. Please advice how the test should be performed.
(and fixed some)
Checklist
Not needed.
Screenshots (if applicable)
No visual change.
Additional Notes
Could anyone help me understand why DeletedAt was used in the first place? Is there any reason for AttributeOverride to soft delete?