fix(thresholds): add observed threshold for attribute 188 with value 0 #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an observed threshold entry for ATA attribute 188 (Command_Timeout) when the value is exactly 0. This fixes incorrect failure rate calculations for drives with zero command timeouts, particularly affecting Seagate drives.
Starosdev
force-pushed
the
fix/upstream-pr-551-attr188-zero-value
branch
from
34e99fb to
c86ee89
Compare
Starosdev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an observed threshold entry for ATA attribute 188 (Command_Timeout) when the value is exactly 0. This fixes incorrect failure rate calculations for drives with zero command timeouts, particularly affecting Seagate drives.
Origin
Changes
Related Issues
Test Plan