Conversation
Adds frontend guards for two scenarios the original fix missed: - 'force_status' action with no status selected - custom threshold with warn_above >= fail_above Both previously allowed form submission but triggered backend 400s.
4 tasks
Starosdev
added a commit
that referenced
this pull request
Apr 30, 2026
…, and bug fixes (#481) ## Summary - Add 12-hour / 24-hour time format preference (#445) - Fix 400 error when adding SMART attribute overrides — block submission when action is empty without thresholds, `force_status` without status, or `warn_above >= fail_above` (#476, #480) - Widen settings dialog to prevent content cutoff (#475) - Auto-add `disabletls=Yes` for Gotify URLs on HTTP ports (#472) - Fix temperature chart tooltip truncation and spike hover (#443) - Add `insecure_skip_verify` option for Uptime Kuma self-signed TLS (#418) - Fix potential memory leak sources in backend (#419) - Fix missing `device_wwn` column in summary query (#423) ## Linked Issues Closes #476 Closes #475 Closes #472 Closes #443 Closes #418 ## Test plan - [x] CI checks passed on develop - [x] Override form blocks submission on all invalid state combinations - [x] Gotify HTTP URLs receive disabletls param automatically - [x] Time format preference persists across sessions
Starosdev
pushed a commit
that referenced
this pull request
Apr 30, 2026
## [1.52.0](v1.51.0...v1.52.0) (2026-04-30) ### Features * **settings:** attribute override validation, time format preference, and bug fixes ([#481](#481)) ([4218085](4218085)), closes [#445](#445) [#476](#476) [#480](#480) [#475](#475) [#472](#472) [#443](#443) [#418](#418) [#419](#419) [#423](#423) [#476](#476) [#475](#475) [#472](#472) [#443](#443) [#418](#418)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
force_statusbut no status is selectedaddOverride()to abort whenforce_statushas no statuswarn_above >= fail_aboveBoth scenarios were accepted by the frontend but rejected by backend validation with a 400, unaddressed by the previous fix in #477.
Linked Issues
Closes #476
Test plan