fix(collector): harden metrics publishing, megaraid dedup, mobile drives tab, MX500 profile#586
Conversation
…o omnibus compose The environment section was nested under volumes (6-space indent) instead of being a service-level key (4-space indent). Uncommented lines would have been parsed as volume entries and rejected by Compose. Also adds COLLECTOR_BTRFS_CRON_SCHEDULE and COLLECTOR_BTRFS_RUN_STARTUP to the commented-out environment examples, and a note about bind-mounting host Btrfs volume paths for platforms like Synology DSM.
When smartctl --scan returns a device entry with an empty name, the collector would construct the path as "/dev/" and invoke smartctl with that invalid path, producing a fatal error and halting collection for the host. Filter out empty-named entries in TransformDetectedDevices with a warning log, and add a secondary guard in SmartCtlInfo.
The flag was missing from the CLI definition; detect.go already reads host.id from config to generate deterministic array IDs.
treo-card sets display:flex (row) but stat cards need column direction for label/value to stack vertically. Affects BTRFS filesystem detail, ZFS pool detail, and drive performance metric cards. Fixes #572.
) Reject devices with no identifying information (device_name, model_name, serial_number, and wwn all empty) in RegisterDevice, preventing the creation of blank orphan rows with a deterministic UUID from all-empty inputs. Add migration m20260528000000 to remove any existing orphan blank rows left by previous collector runs or backfill migrations.
fix(collector): add --host-id flag to MDADM collector (SCR-573)
…e-rows fix(database): prevent orphan blank device rows after registration (#567)
# Conflicts: # webapp/backend/pkg/thresholds/consumer_drive_profiles_test.go
Convert heavy value params to pointers (gocritic hugeParam), reorder struct fields (govet fieldalignment), and remove err variable shadowing (govet shadow). No behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Explicitly discard ignored errors from SmartCtlInfo and populateUdevInfo (errcheck) and fix comment spacing (gocritic). Linux-only file not caught by darwin lint runs.
Starosdev
pushed a commit
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linked Issues
Closes #582
Closes #580
Closes #583
Test plan