Skip to content

feat: upgrade toolchain to nightly-2025-12-12#90

Merged
AsakuraMizu merged 1 commit intomainfrom
dev/toolchain
Dec 16, 2025
Merged

feat: upgrade toolchain to nightly-2025-12-12#90
AsakuraMizu merged 1 commit intomainfrom
dev/toolchain

Conversation

@AsakuraMizu
Copy link
Contributor

@AsakuraMizu AsakuraMizu commented Dec 16, 2025

Copilot AI review requested due to automatic review settings December 16, 2025 06:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the Rust toolchain from nightly-2025-05-20 to nightly-2025-12-12, updating code to comply with newer compiler requirements around explicit lifetime annotations and modern API usage.

Key Changes:

  • Toolchain updated to nightly-2025-12-12
  • Added explicit lifetime parameters ('_) to Cow return types across multiple file implementations
  • Replaced deprecated modulo checks with is_multiple_of() method
  • Updated PartialOrd implementation to use Ord::cmp() method

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
rust-toolchain.toml Updates toolchain channel to nightly-2025-12-12
core/src/vfs/file.rs Adds explicit lifetime annotations to Cow<[u8]> return types
core/src/time.rs Refactors PartialOrd implementation to delegate to Ord::cmp()
core/src/futex.rs Adds explicit lifetime annotations to FutexGuard return types
arceos Updates subproject commit hash
api/src/syscall/task/thread.rs Moves unused import to inline usage and adds architecture-specific conditional compilation
api/src/syscall/mm/mmap.rs Replaces modulo check with is_multiple_of() method
api/src/lib.rs Removes maybe_uninit_slice feature flag
api/src/syscall/fs/io.rs Adds explicit lifetime annotation to path() return type
api/src/file/signalfd.rs Adds explicit lifetime annotation to path() return type
api/src/file/pipe.rs Adds explicit lifetime annotation to path() return type
api/src/file/pidfd.rs Adds explicit lifetime annotation to path() return type
api/src/file/net.rs Adds explicit lifetime annotation to path() return type
api/src/file/mod.rs Adds explicit lifetime annotation to trait method path() return type
api/src/file/fs.rs Adds explicit lifetime annotation to path() return type
api/src/file/event.rs Adds explicit lifetime annotation to path() return type
api/src/file/epoll.rs Adds explicit lifetime annotation to path() return type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AsakuraMizu AsakuraMizu changed the title feat: upgrade toolchain to 2025-12-12 feat: upgrade toolchain to nightly-2025-12-12 Dec 16, 2025
@AsakuraMizu AsakuraMizu merged commit 97d7c9d into main Dec 16, 2025
18 of 19 checks passed
@AsakuraMizu AsakuraMizu deleted the dev/toolchain branch December 16, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant