feat: upgrade toolchain to nightly-2025-12-12#90
Merged
AsakuraMizu merged 1 commit intomainfrom Dec 16, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Rust toolchain from nightly-2025-05-20 to nightly-2025-12-12, updating code to comply with newer compiler requirements around explicit lifetime annotations and modern API usage.
Key Changes:
- Toolchain updated to nightly-2025-12-12
- Added explicit lifetime parameters (
'_) toCowreturn types across multiple file implementations - Replaced deprecated modulo checks with
is_multiple_of()method - Updated
PartialOrdimplementation to useOrd::cmp()method
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rust-toolchain.toml | Updates toolchain channel to nightly-2025-12-12 |
| core/src/vfs/file.rs | Adds explicit lifetime annotations to Cow<[u8]> return types |
| core/src/time.rs | Refactors PartialOrd implementation to delegate to Ord::cmp() |
| core/src/futex.rs | Adds explicit lifetime annotations to FutexGuard return types |
| arceos | Updates subproject commit hash |
| api/src/syscall/task/thread.rs | Moves unused import to inline usage and adds architecture-specific conditional compilation |
| api/src/syscall/mm/mmap.rs | Replaces modulo check with is_multiple_of() method |
| api/src/lib.rs | Removes maybe_uninit_slice feature flag |
| api/src/syscall/fs/io.rs | Adds explicit lifetime annotation to path() return type |
| api/src/file/signalfd.rs | Adds explicit lifetime annotation to path() return type |
| api/src/file/pipe.rs | Adds explicit lifetime annotation to path() return type |
| api/src/file/pidfd.rs | Adds explicit lifetime annotation to path() return type |
| api/src/file/net.rs | Adds explicit lifetime annotation to path() return type |
| api/src/file/mod.rs | Adds explicit lifetime annotation to trait method path() return type |
| api/src/file/fs.rs | Adds explicit lifetime annotation to path() return type |
| api/src/file/event.rs | Adds explicit lifetime annotation to path() return type |
| api/src/file/epoll.rs | Adds explicit lifetime annotation to path() return type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: