Skip to content
This repository was archived by the owner on Apr 27, 2019. It is now read-only.

Development#124

Merged
kharidiron merged 37 commits intoStarryPy:developmentfrom
kharidiron:development
Feb 7, 2015
Merged

Development#124
kharidiron merged 37 commits intoStarryPy:developmentfrom
kharidiron:development

Conversation

@kharidiron
Copy link
Copy Markdown
Member

All my changes to-date.

…n. added own comment directives in per-packet to help keep track.
…fixed client crash on first connect to server (resulting from give item)
…mand out of command dispatecher, and into warpy. Ship warping still DOES NOT WORK. Packet parsing issues remain to be sorted out.
I removed the extra logging-level that was put in (TRACE), and instead pushed everything onto DEBUG. In addition, I modified the default options the live in the config.json file. My reasoning is that, logging was somewhat confusing, and the way it was setup carried more options than were needed. Instead, the server-owner need-only choose their logging-level from the config file, and run the server. In turn, the server now pushes all logging information into one central log-file, to reduce redundancy. I will likely add another log level back in for packet-dumping, since that is sometimes more than what debug needs as well.
…nvenince command based on the PoI system. Ship-to-ship warping does not work currently. My guess is that, reading celestial coordinates from a player's protocol is currently not working as expected. This is less imporant for production, so I'll fix it whenever I get to it.
…arding 'local' chat skipping IRC. Added uptime plugin
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if not data:, wouldn't be better?

@8r2y5
Copy link
Copy Markdown
Contributor

8r2y5 commented Feb 6, 2015

After all, 👍. Great that code is working with newest version of Starbound! \o/

@kharidiron
Copy link
Copy Markdown
Member Author

After a bit of discussion in the IRC, we are going to stick with the use of if len(x) == 0 style of condition. The changes you're suggest are more pythonic, but do not provide any performance benefit. In this case, being explicit is likely to be better, and we don't suffer from any ambiguity in the process.

kharidiron added a commit that referenced this pull request Feb 7, 2015
Merging changes in. Soon on to master!
@kharidiron kharidiron merged commit 6de08ad into StarryPy:development Feb 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants