Merged
Conversation
To release the memory usage in LD-free mode, we pre-set LD = 1 instead of a diagonal matrix. However, using sum(LD) == 1 to check LD is pretty computational entensive. We changed to use length(LD) == 1 instead, which is saving a lot of computational time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reduce memory usage in LD-free mode, we pre-set LD = 1 instead of using a diagonal matrix. However, checking whether LD is in this simplified form using sum(LD) == 1 is computationally expensive. We optimized this by switching to length(LD) == 1, which provides the same logical check but with significantly reduced computational overhead.