Add regularized regression methods and improve some tests#467
Merged
danielnachun merged 12 commits intomainfrom Apr 13, 2026
Merged
Add regularized regression methods and improve some tests#467danielnachun merged 12 commits intomainfrom
danielnachun merged 12 commits intomainfrom
Conversation
aac7640 to
c862b5f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
===========================================
+ Coverage 27.48% 76.70% +49.21%
===========================================
Files 32 41 +9
Lines 4377 7941 +3564
===========================================
+ Hits 1203 6091 +4888
+ Misses 3174 1850 -1324 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for several new regression methods to match what is available in the mr.ash paper.
I have also worked to maximize test coverage for the fine mapping, TWAS and regularized regression code.
I had to disable the tests and code that rely on summary-based methods for qgg because these are missing from the current CRAN version of qgg. It seems the authors are actively updating their code over the last few days, so they may be preparing a new release. If one doesn't come out soon, we should contact them.