Skip to content

Add regularized regression methods and improve some tests#467

Merged
danielnachun merged 12 commits intomainfrom
add-regularized-regression-methods
Apr 13, 2026
Merged

Add regularized regression methods and improve some tests#467
danielnachun merged 12 commits intomainfrom
add-regularized-regression-methods

Conversation

@danielnachun
Copy link
Copy Markdown
Collaborator

@danielnachun danielnachun commented Apr 12, 2026

This PR adds support for several new regression methods to match what is available in the mr.ash paper.

I have also worked to maximize test coverage for the fine mapping, TWAS and regularized regression code.

I had to disable the tests and code that rely on summary-based methods for qgg because these are missing from the current CRAN version of qgg. It seems the authors are actively updating their code over the last few days, so they may be preparing a new release. If one doesn't come out soon, we should contact them.

@danielnachun danielnachun force-pushed the add-regularized-regression-methods branch from aac7640 to c862b5f Compare April 13, 2026 08:54
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 95.34884% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.70%. Comparing base (0517999) to head (69659bd).
⚠️ Report is 1026 commits behind head on main.

Files with missing lines Patch % Lines
R/regularized_regression.R 95.12% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #467       +/-   ##
===========================================
+ Coverage   27.48%   76.70%   +49.21%     
===========================================
  Files          32       41        +9     
  Lines        4377     7941     +3564     
===========================================
+ Hits         1203     6091     +4888     
+ Misses       3174     1850     -1324     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielnachun danielnachun merged commit 3396bee into main Apr 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant