Feature: recommended people name to add from RMarkDown & Quarto#336
Conversation
Signed-off-by: Ayush <bhandariayush935@gmail.com>
|
@lrasmus , |
lrasmus
left a comment
lrasmus
left a comment
There was a problem hiding this comment.
This is a very helpful and clean implementation - thank you as well for ensuring there are unit tests. I had two small suggested changes for you to consider. Thank you!
| if (option.userEntry) { | ||
| return `${GeneralUtil.formatName(option.name)} (me)`; | ||
| } else if (option.extractedEntry) { | ||
| return `${GeneralUtil.formatName(option.name)}`; |
There was a problem hiding this comment.
I'm wondering if we could simplify and use the previous code that was here before? Let me know if I'm reading this wrong, but there doesn't appear to be any special formatting required for extracted entries, correct? If so, we could probably do:
option.userEntry
? `${GeneralUtil.formatName(option.name)} (me)`
: GeneralUtil.formatName(option.name)
There was a problem hiding this comment.
Sorry ,
I was planning to add (but it seems i forgot 😅)
else if (option.extractedEntry) { return ${GeneralUtil.formatName(option.name)} (Extracted) ;
It would differentiate between normal and extracted entry,
Just want your thought on it
There was a problem hiding this comment.
Gotcha! How about "(Detected)" instead of "(Extracted)"? But I like the idea of having that labeled. Thanks!
There was a problem hiding this comment.
Totally awesome ,
just implementing it
Signed-off-by: Ayush <bhandariayush935@gmail.com>
Signed-off-by: Ayush <bhandariayush935@gmail.com>
Signed-off-by: Ayush <bhandariayush935@gmail.com>
2 participants
Description
This features scans the directory and & sub-directory also and finds the suitable files (RMarkDown & Quarto) , If the data written in proper format, So fetches Author field data and made available to the UI.
Related Issues
Issue #303
Screen Recording
2026-03-12.12-29-17.mp4
Additional Information