Skip to content

Backend/deviations#33

Merged
Oleandertengesdal merged 7 commits intomainfrom
backend/deviations
Apr 9, 2026
Merged

Backend/deviations#33
Oleandertengesdal merged 7 commits intomainfrom
backend/deviations

Conversation

@SindreJB
Copy link
Copy Markdown
Collaborator

@SindreJB SindreJB commented Apr 8, 2026

Built the ramaining endpoints according to backend-krav.md

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Backend Test Results

141 tests   135 ✅  5s ⏱️
 35 suites    0 💤
 35 files      1 ❌  5 🔥

For more details on these failures and errors, see this check.

Results for commit 9d95e24.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the deviations backend with “details” retrieval (including comment log), comment creation, and a more general status update flow, backed by new persistence structures.

Changes:

  • Added deviation details endpoint (GET /api/deviations/{id}) returning a DeviationDetailsResponse including comment log and relatedReadingId.
  • Added endpoints for status updates and adding comments, with corresponding service logic and DTOs.
  • Extended the database schema with related_reading_id on deviations and introduced the deviation_comments table + indexes.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
backend/src/main/java/backend/fullstack/deviations/api/DeviationController.java Adds deviation details/status/comment endpoints and security annotations
backend/src/main/java/backend/fullstack/deviations/application/DeviationService.java Implements details retrieval, status transitions, and comment creation
backend/src/main/java/backend/fullstack/deviations/domain/Deviation.java Adds related reading + comment relationship helpers
backend/src/main/java/backend/fullstack/deviations/domain/DeviationComment.java New JPA entity for deviation comments
backend/src/main/java/backend/fullstack/deviations/infrastructure/DeviationCommentRepository.java New repository for comment log queries
backend/src/main/java/backend/fullstack/deviations/api/dto/DeviationDetailsResponse.java New response DTO for deviation details view
backend/src/main/java/backend/fullstack/deviations/api/dto/DeviationCommentRequest.java New request DTO for comment creation
backend/src/main/java/backend/fullstack/deviations/api/dto/DeviationCommentResponse.java New response DTO for comment log items
backend/src/main/java/backend/fullstack/deviations/api/dto/UpdateDeviationStatusRequest.java New request DTO for general status updates
backend/src/main/resources/db/migration/V10__extend_deviation_domain.sql Adds related reading FK + creates deviation_comments table and indexes
backend/src/test/java/backend/fullstack/deviations/application/DeviationServiceTest.java Adds tests for new service behaviors (status, comments, details)
backend/src/test/java/backend/fullstack/deviations/api/DeviationControllerTest.java Adds controller test for details endpoint response shape
backend/src/test/java/backend/fullstack/deviations/api/DeviationControllerSecurityAnnotationsTest.java Adds security annotation assertions for new controller methods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Oleandertengesdal Oleandertengesdal merged commit c671b84 into main Apr 9, 2026
0 of 3 checks passed
@SindreJB SindreJB deleted the backend/deviations branch April 10, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants