Skip to content

No changes - review fixes already merged in PR #15#18

Merged
Steake merged 1 commit intotournament-mii-plus-systemfrom
copilot/sub-pr-14-again
Nov 28, 2025
Merged

No changes - review fixes already merged in PR #15#18
Steake merged 1 commit intotournament-mii-plus-systemfrom
copilot/sub-pr-14-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 28, 2025

This branch was created to address review comments from PR #14, but those fixes were already applied and merged in PR #15.

Fixes already merged in PR #15

  • Lexicographic tiebreaker: Added glider position to hash calculation, handled hash equality case
  • Noise placement: Skip cells already occupied by gliders to prevent overwrites
  • Integer overflow: Added height == 0 validation in blocks API
  • Dependencies: Removed unused bitcell-ebsl and thiserror from bitcell-simulation
  • Cargo.toml: Fixed workspace member formatting (one per line)
  • Miner positions: Added derive_position_from_pubkey() for varied spawn positions in simulation
  • Test coverage: Added assertion that Tie outcome never occurs with MII+ tiebreaker

No additional changes needed on this branch.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Add MII+ tournament system with adaptive strategy No changes - review fixes already merged in PR #15 Nov 28, 2025
Copilot AI requested a review from Steake November 28, 2025 13:34
@Steake Steake marked this pull request as ready for review November 28, 2025 13:36
Copilot AI review requested due to automatic review settings November 28, 2025 13:36
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Steake Steake merged commit 43d9e05 into tournament-mii-plus-system Nov 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants