Skip to content

Fix: 11 remaining NLU/NLG source-divergence test failures (Phase 2 deferred) #91

@Steake

Description

@Steake

Context

PR #90 resolved 55 of the 66 remaining test failures from issue #73. The following 11 failures were deferred as they require genuine module-level source rewrites, not test patches.

Root causes identified

  • Source implementations have diverged from the interfaces the tests were written against
  • Method signatures, return types, or class structures no longer match test expectations
  • These are not environmental — spaCy skip guards were applied in Fix: remaining 66 test failures from Phase 2 (Categories 1–4) #90 for the 7 environmental failures; these 11 are genuine code divergence

What needs doing

Work through each failing test in tests/nlu_nlg/nlu/ and tests/nlu_nlg/nlg/ file by file:

  1. Read the test expectations
  2. Read the current source implementation
  3. Align the source to the test contract (preferred) OR update the test if the source represents correct intended behaviour
  4. Do not skip — these need to actually pass

Files in scope

  • tests/nlu_nlg/nlu/ — NLU parser/pipeline tests
  • tests/nlu_nlg/nlg/ — NLG generator tests
  • Corresponding source: godelOS/nlu_nlg/

Acceptance criteria

All 11 previously-failing tests pass without skipif guards.

Related: #73, #90

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions