Update Glacier Engine Description#841
Merged
Lifeismana merged 2 commits intoSteamDatabase:mainfrom Aug 4, 2024
thecatontheceiling:main
Merged
Update Glacier Engine Description#841Lifeismana merged 2 commits intoSteamDatabase:mainfrom thecatontheceiling:main
Lifeismana merged 2 commits intoSteamDatabase:mainfrom
thecatontheceiling:main
Conversation
woah look at this new sexy description! the old one was very smelly and stinky :(
Contributor
Author
|
alright I'll add new rules to this PR :P would it be a good idea to separate Glacier and Glacier 2 from each other? Glacier 2 is technically just a rewrite of Glacier but the engines work so differently that imo it warrants separation. |
Contributor
Author
|
I checked rules.ini and the only exception seems to be Source and Source 2. idk why they made an exception for that since Source 2 wasn't written from scratch and is somewhat based on Source, just like Glacier. anyway to avoid asking too many questions I'll just combine glacier 1 and glacier 2 rules together into just "glacier" |
Lifeismana
reviewed
Aug 4, 2024
Collaborator
|
make a new PR if you want to update the rule |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SteamDB app page links to a few games using this
The rules also need to be updated to detect Glacier 1 and Hitman: Absolution because as of right now it only detects Hitman 2016 and newer. I might make a PR for that too.
Correctly detected:
https://steamdb.info/app/1659040/
https://steamdb.info/app/863550/
https://steamdb.info/app/236870/
False Negatives:
https://steamdb.info/app/203140/
https://steamdb.info/app/205930/
https://steamdb.info/app/247430/
https://steamdb.info/app/6860/
https://steamdb.info/app/6850/
https://steamdb.info/app/6900/
https://steamdb.info/app/1347780/
https://steamdb.info/app/8080/
https://steamdb.info/app/28000/
https://steamdb.info/app/35000/
Brief explanation of the change
woah look at this new sexy description! the old one was very smelly and stinky :(