Add AMD features & update older AMD rules.#925
Add AMD features & update older AMD rules.#925Lifeismana merged 10 commits intoSteamDatabase:mainfrom
Conversation
Added: AMD_FSR_SDK[] AMD_FidelityFX_FSR2 AMD_FSR_Upscaling AMD_FSR_RayRegen AMD_FSR_FrameGen Updated: AMD_FidelityFX_SDK[]
Removed SDK.AMD_FidelityFX.md. Added descriptions for: SDK.AMD_FidelityFX_FSR2.md SDK.AMD_FidelityFX_SDK.md SDK.AMD_FSR_FrameGen.md SDK.AMD_FSR_RayRegen.md SDK.AMD_FSR_SDK.md SDK.AMD_FSR_Upscaling.md
Added Non Matching Tests for: AMD_FSR_FrameGen AMD_FSR_RayRegen AMD_FSR_SDK AMD_FSR_Upscaling
Added tests for: SDK.AMD_FidelityFX_FSR2 SDK.AMD_FidelityFX_SDK SDK.AMD_FSR_FrameGen SDK.AMD_FSR_RayRegen SDK.AMD_FSR_SDK SDK.AMD_FSR_Upscaling
|
Is fsr upscaling actually separate to fsr sdk? because I'd like to avoid having too many different technologies that are very related. |
Yes, the SDK contains multiple technologies (both the old FidelityFX and FSR SDK). There is no guarantee a title using the SDK alone is definitely using upscaling or other technologies. FSR is now the overall brand for our technologies and not an indicator that all of the technologies are upscaling. |
|
Unsure why the test is failing, those paths are correct for SDK.AMD_FSR_Upscaling. |
|
Duplicate regex |
Ok. So it is not allowed for a single .dll to trigger multiple rules? |
|
Correct. |
|
I removed the duplicate regex. |
Lifeismana
left a comment
There was a problem hiding this comment.
bunch of nitpicks & reduces the size of descriptions
Co-authored-by: Antoine Rybacki <15911822+Lifeismana@users.noreply.github.com>
Co-authored-by: Antoine Rybacki <15911822+Lifeismana@users.noreply.github.com>
Co-authored-by: Antoine Rybacki <15911822+Lifeismana@users.noreply.github.com>
Co-authored-by: Antoine Rybacki <15911822+Lifeismana@users.noreply.github.com>
|
There are over 1000 entries but I took around 50 at random from the entire list and they all had 1 or more of the DLLs. Let me know if you want me to check more. |
|
nah it should be good |
|
Thank you both! |
SteamDB app page links to a few games using this
https://steamdb.info/depot/2807961/
https://steamdb.info/depot/1808501/
https://steamdb.info/depot/3065801/
https://steamdb.info/depot/1363081/
Brief explanation of the change
Updated FidelityFX SDK rule to reflect recent changes and separated FSR 2 to a separate rule. Added rules for FSR SDK vs older FidelityFX SDK. Added additional rules for AMD Features including: FSR Upscaling, FSR Frame Generation, FSR Ray Regeneration.
All tests passed.