Conversation
This fixes last of generation errors.
|
I suggest removing That has all the new fields, except for 200/201 which I suspect are only sent between GC servers anyway. |
voided
left a comment
There was a problem hiding this comment.
Can we take CS:GO's GC protobuf header for our gc.proto?
They've got an extra ip field which you wouldn't be able to get at otherwise.
Ideally sometime in the future we can maybe make the headers pluggable depending on what GC you're talking to - and this would become even more important if they ever diverge (hasn't happened so far...).
voided
left a comment
There was a problem hiding this comment.
Just needs another regen, but this looks good to me.
|
Note to self: close #16 on merge. |
|
|
||
| Push-Location | ||
|
|
||
| $protos = Import-Csv -LiteralPath (Join-Path $PSScriptRoot 'protos.csv') | |
|
Probably something for a later stage, but I'd love to have this automatically submit a PR when the protobufs repo gets updated. |
|
Build error is in NHA2:
|
|
@yaakov-h That proto only exists in CS:GO now: https://github.com/SteamDatabase/Protobufs/search?q=CSOPartyInvite&unscoped_q=CSOPartyInvite It was generated from tf2 beta before. |
Codecov Report
@@ Coverage Diff @@
## master #610 +/- ##
==========================================
- Coverage 23.63% 23.61% -0.03%
==========================================
Files 85 85
Lines 8694 8694
Branches 719 719
==========================================
- Hits 2055 2053 -2
Misses 6508 6508
- Partials 131 133 +2
Continue to review full report at Codecov.
|
As discussed from time to time, use SteamDB's Protobufs submodule instead of continuing to maintain our own. This makes keeping up to date simpler.
Using
https://github.com/SteamDatabase/Protobufs
Since we can't have individual generate scripts for each app in the folder with their proto files, instead switched to single script to regenerate all, running from the Protogen folder. If that's not desired, we can still do individual bats, just ran from elsewhere. This just removed much of the boilerplate needed.
Also, with this change, the classes for the new Steam chat are using the protos from Steam Client itself, rather than from the friends js.