Skip to content

Comments

Use protobufs from submodule#610

Merged
psychonic merged 13 commits intomasterfrom
protobuf-submodule
Nov 26, 2018
Merged

Use protobufs from submodule#610
psychonic merged 13 commits intomasterfrom
protobuf-submodule

Conversation

@psychonic
Copy link
Member

As discussed from time to time, use SteamDB's Protobufs submodule instead of continuing to maintain our own. This makes keeping up to date simpler.

Using
https://github.com/SteamDatabase/Protobufs

Since we can't have individual generate scripts for each app in the folder with their proto files, instead switched to single script to regenerate all, running from the Protogen folder. If that's not desired, we can still do individual bats, just ran from elsewhere. This just removed much of the boilerplate needed.

Also, with this change, the classes for the new Steam chat are using the protos from Steam Client itself, rather than from the friends js.

@xPaw
Copy link
Member

xPaw commented Nov 25, 2018

I suggest removing gc.proto and using the proto from steam/steammessages_base.proto instead.

That has all the new fields, except for 200/201 which I suspect are only sent between GC servers anyway.

Copy link
Member

@voided voided left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we take CS:GO's GC protobuf header for our gc.proto?

They've got an extra ip field which you wouldn't be able to get at otherwise.

Ideally sometime in the future we can maybe make the headers pluggable depending on what GC you're talking to - and this would become even more important if they ever diverge (hasn't happened so far...).

Copy link
Member

@voided voided left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs another regen, but this looks good to me.

@voided voided requested a review from yaakov-h November 25, 2018 19:26
@yaakov-h
Copy link
Member

Note to self: close #16 on merge.


Push-Location

$protos = Import-Csv -LiteralPath (Join-Path $PSScriptRoot 'protos.csv') |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@yaakov-h
Copy link
Member

Probably something for a later stage, but I'd love to have this automatically submit a PR when the protobufs repo gets updated.

@yaakov-h
Copy link
Member

yaakov-h commented Nov 26, 2018

Build error is in NHA2:

Specializations\TF2\TF2SOHelper.cs(21,27): error CS0246: The type or namespace name 'CSOPartyInvite' could not be found (are you missing a using directive or an assembly reference?)

@xPaw
Copy link
Member

xPaw commented Nov 26, 2018

@yaakov-h That proto only exists in CS:GO now: https://github.com/SteamDatabase/Protobufs/search?q=CSOPartyInvite&unscoped_q=CSOPartyInvite

It was generated from tf2 beta before.

@codecov-io
Copy link

codecov-io commented Nov 26, 2018

Codecov Report

Merging #610 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #610      +/-   ##
==========================================
- Coverage   23.63%   23.61%   -0.03%     
==========================================
  Files          85       85              
  Lines        8694     8694              
  Branches      719      719              
==========================================
- Hits         2055     2053       -2     
  Misses       6508     6508              
- Partials      131      133       +2
Impacted Files Coverage Δ
SteamKit2/SteamKit2/Steam/WebAPI/WebAPI.cs 41.34% <0%> (-0.49%) ⬇️
SteamKit2/SteamKit2/Types/SteamID.cs 79.42% <0%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e4e928...e403beb. Read the comment docs.

@psychonic psychonic merged commit aa01a37 into master Nov 26, 2018
@psychonic psychonic deleted the protobuf-submodule branch January 18, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants