Fix for NetworkInformationException#630
Merged
yaakov-h merged 3 commits intoSteamRE:masterfrom Jan 22, 2019
felipe19930:master
Merged
Fix for NetworkInformationException#630yaakov-h merged 3 commits intoSteamRE:masterfrom felipe19930:master
yaakov-h merged 3 commits intoSteamRE:masterfrom
felipe19930:master
Conversation
JustArchi
approved these changes
Jan 22, 2019
Contributor
There was a problem hiding this comment.
The PR itself looks good enough and fixes the issue, I also don't see any drawbacks to accepting it. Any potential improvements to the underlying SK2 logic should be done in separate PRs, if somebody will come up with a better solution considering newly-discovered details, of course.
Member
|
This catches a documented exception. 👍 |
yaakov-h
requested changes
Jan 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
=========================================
+ Coverage 23.59% 23.6% +0.01%
=========================================
Files 85 85
Lines 8709 8713 +4
Branches 719 719
=========================================
+ Hits 2055 2057 +2
- Misses 6523 6525 +2
Partials 131 131
Continue to review full report at Codecov.
|
yaakov-h
approved these changes
Jan 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #629