Add ParentalSettings to LoggedOnCallback#707
Merged
yaakov-h merged 2 commits intoSteamRE:masterfrom Aug 16, 2019
JustArchi:archi-parental
Merged
Add ParentalSettings to LoggedOnCallback#707yaakov-h merged 2 commits intoSteamRE:masterfrom JustArchi:archi-parental
yaakov-h merged 2 commits intoSteamRE:masterfrom
JustArchi:archi-parental
Conversation
JustArchi
commented
Jul 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
==========================================
- Coverage 24.38% 24.36% -0.03%
==========================================
Files 89 89
Lines 8800 8808 +8
Branches 742 743 +1
==========================================
Hits 2146 2146
- Misses 6522 6530 +8
Partials 132 132
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've verified that this works properly, and it's a big help for those apps that want/need to interpret those settings, for example in order to determine if
ParentalSettings.is_enabled.I could expose
resp.parental_settingsalone and expect from the consumer to do the deserialization himself, but I believe that we can aid him a little since there is nothing else he should be doing with that data anyway. Let me know if there is anything you'd change in this implementation.Thank you in advance for considering this PR.