Implement CMsgIPAddress#770
Merged
yaakov-h merged 6 commits intoSteamRE:masterfrom May 14, 2020
xPaw:CMsgIPAddress
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #770 +/- ##
==========================================
+ Coverage 22.89% 23.07% +0.18%
==========================================
Files 95 95
Lines 9283 9368 +85
Branches 779 784 +5
==========================================
+ Hits 2125 2162 +37
- Misses 7024 7071 +47
- Partials 134 135 +1
Continue to review full report at Codecov.
|
yaakov-h
reviewed
Apr 18, 2020
Member
|
My guess on |
Member
Author
|
I added method extensions onto |
yaakov-h
approved these changes
Apr 18, 2020
Member
yaakov-h
left a comment
There was a problem hiding this comment.
Not entirely sold on the RollForward but I think the v6 stuff looks right now.
yaakov-h
requested changes
May 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

NetHelpers.TryParseIPEndPointdoesn't support IPv6 bracket notationLoginIDin logon just sets v4 - i don't think this a big of an issueCMsgGSServerTypehasdeprecated_game_ip_address, but there are no other fields for IPI can't test any of this because there's no way of getting ipv6 cm servers anywhere yet.