Remove sent/recv debug messages#774
Merged
yaakov-h merged 2 commits intoSteamRE:masterfrom Nov 2, 2019
xPaw:patch-7
Merged
Conversation
DebugNetworkListener can be used for this purpose.
Codecov Report
@@ Coverage Diff @@
## master #774 +/- ##
==========================================
- Coverage 22.76% 22.74% -0.02%
==========================================
Files 94 94
Lines 9304 9306 +2
Branches 770 770
==========================================
- Hits 2118 2117 -1
- Misses 7052 7055 +3
Partials 134 134
Continue to review full report at Codecov.
|
Member
|
I find these useful. 😢 Can we move it to DebugNetworkListener? |
Member
Author
|
I added them to |
Member
|
I think so. That should be the EMsg without the high-bit for proto. |
Member
Author
|
It practically logs in the same place as the logs i removed (except for the fact that multis will be split). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DebugNetworkListener can be used for this purpose.
This will actually make DebugLog easier to enable without having to worry about the packet spam.