Add a per-SteamClient unique identifier message to DebugLog messages (2)#777
Merged
yaakov-h merged 5 commits intoSteamRE:masterfrom Nov 4, 2019
Merged
Conversation
xPaw
reviewed
Nov 3, 2019
| /// <summary> | ||
| /// A unique identifier for this client instance. | ||
| /// </summary> | ||
| public string ID { get; } |
Member
Author
There was a problem hiding this comment.
Should be immutable for the object’s lifetime, so perhaps a constructor parameter?
JustArchi
reviewed
Nov 3, 2019
| /// <summary> | ||
| /// A unique identifier for this client instance. | ||
| /// </summary> | ||
| public string ID { get; } |
Contributor
There was a problem hiding this comment.
All fine but a setter would indeed be nice, see my reasoning in #503 (comment)
Codecov Report
@@ Coverage Diff @@
## master #777 +/- ##
==========================================
+ Coverage 22.74% 22.77% +0.02%
==========================================
Files 94 95 +1
Lines 9306 9329 +23
Branches 770 772 +2
==========================================
+ Hits 2117 2125 +8
- Misses 7055 7070 +15
Partials 134 134
Continue to review full report at Codecov.
|
xPaw
approved these changes
Nov 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A different approach to solving #503.
Thoughts?
This version should not trigger breaking changes in consumers.
cc/ @JustArchi @xPaw