Restore response status code in exception messages#779
Merged
yaakov-h merged 4 commits intoSteamRE:masterfrom Nov 4, 2019
RudeySH:master
Merged
Restore response status code in exception messages#779yaakov-h merged 4 commits intoSteamRE:masterfrom RudeySH:master
yaakov-h merged 4 commits intoSteamRE:masterfrom
RudeySH:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #779 +/- ##
==========================================
+ Coverage 22.73% 22.77% +0.04%
==========================================
Files 94 95 +1
Lines 9311 9329 +18
Branches 771 772 +1
==========================================
+ Hits 2117 2125 +8
- Misses 7060 7070 +10
Partials 134 134
Continue to review full report at Codecov.
|
yaakov-h
requested changes
Nov 4, 2019
yaakov-h
approved these changes
Nov 4, 2019
Member
|
Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating my SteamKit dependency from 2.1.0 to 2.2.0, I noticed the exception messages from Web API requests were slightly different. Before 2.2.0, an example exception message looked like this:
But now after updating to 2.2.0, the same message looks like this:
This change was caused by #603 and is most likely unintentional. My pull requests restores the original exception messages.