Skip to content

Comments

Restore response status code in exception messages#779

Merged
yaakov-h merged 4 commits intoSteamRE:masterfrom
RudeySH:master
Nov 4, 2019
Merged

Restore response status code in exception messages#779
yaakov-h merged 4 commits intoSteamRE:masterfrom
RudeySH:master

Conversation

@RudeySH
Copy link
Contributor

@RudeySH RudeySH commented Nov 4, 2019

After updating my SteamKit dependency from 2.1.0 to 2.2.0, I noticed the exception messages from Web API requests were slightly different. Before 2.2.0, an example exception message looked like this:

Response status code does not indicate success: 403 (Forbidden).

But now after updating to 2.2.0, the same message looks like this:

Response status code does not indicate success: Forbidden (Forbidden).

This change was caused by #603 and is most likely unintentional. My pull requests restores the original exception messages.

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #779 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
+ Coverage   22.73%   22.77%   +0.04%     
==========================================
  Files          94       95       +1     
  Lines        9311     9329      +18     
  Branches      771      772       +1     
==========================================
+ Hits         2117     2125       +8     
- Misses       7060     7070      +10     
  Partials      134      134
Impacted Files Coverage Δ
SteamKit2/SteamKit2/Steam/WebAPI/WebAPI.cs 57.79% <100%> (ø) ⬆️
SteamKit2/SteamKit2/Steam/CDNClient.cs 20.23% <100%> (ø) ⬆️
...SteamKit2/Networking/Steam3/NetFilterEncryption.cs 0% <0%> (ø) ⬆️
SteamKit2/SteamKit2/Util/DebugNetworkListener.cs 0% <0%> (ø) ⬆️
...mKit2/SteamKit2/Networking/Steam3/UdpConnection.cs 0% <0%> (ø) ⬆️
...2/Networking/Steam3/NetFilterEncryptionWithHMAC.cs 0% <0%> (ø) ⬆️
...SteamKit2/Networking/Steam3/WebSocketConnection.cs 0% <0%> (ø) ⬆️
...mKit2/SteamKit2/Networking/Steam3/TcpConnection.cs 0% <0%> (ø) ⬆️
SteamKit2/SteamKit2/Util/ILogContext.cs 100% <0%> (ø)
...eamKit2/SteamKit2/Steam/SteamClient/SteamClient.cs 47.08% <0%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a1b475...e82dcd9. Read the comment docs.

@yaakov-h yaakov-h added the bug label Nov 4, 2019
@yaakov-h yaakov-h added this to the 2.3.0 milestone Nov 4, 2019
@yaakov-h yaakov-h merged commit 946b779 into SteamRE:master Nov 4, 2019
@yaakov-h
Copy link
Member

yaakov-h commented Nov 4, 2019

Thanks!

@xPaw xPaw mentioned this pull request Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants