Skip to content

Comments

Remove Max value from enums and update some#849

Merged
yaakov-h merged 5 commits intoSteamRE:masterfrom
xPaw:fix-571
May 16, 2020
Merged

Remove Max value from enums and update some#849
yaakov-h merged 5 commits intoSteamRE:masterfrom
xPaw:fix-571

Conversation

@xPaw
Copy link
Member

@xPaw xPaw commented May 14, 2020 •
edited
Loading

No description provided.

@yaakov-h yaakov-h linked an issue May 15, 2020 that may be closed by this pull request
Are "Max" values necessary in enums #571
Closed
@yaakov-h yaakov-h mentioned this pull request May 15, 2020
Closed
@yaakov-h
Copy link
Member

yaakov-h commented May 15, 2020 

Build FAILED.
Types\SteamID.cs(462,99): error CS0117: 'EAccountType' does not contain a definition for 'Max' [C:\projects\steamkit\SteamKit2\SteamKit2\SteamKit2.csproj]
Types\SteamID.cs(465,101): error CS0117: 'EUniverse' does not contain a definition for 'Max' [C:\projects\steamkit\SteamKit2\SteamKit2\SteamKit2.csproj]
    0 Warning(s)
    2 Error(s)
Time Elapsed 00:00:27.28

😢

JustArchi
JustArchi reviewed May 15, 2020
View reviewed changes
@yaakov-h yaakov-h merged commit 9d42533 into SteamRE:master May 16, 2020
@xPaw xPaw deleted the fix-571 branch June 18, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaakov-h yaakov-h yaakov-h left review comments

+1 more reviewer

@JustArchi JustArchi JustArchi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Are "Max" values necessary in enums

3 participants

@xPaw @yaakov-h @JustArchi