Fix race condition in CMClient.Send#913
Merged
azuisleet merged 1 commit intoSteamRE:masterfrom Sep 1, 2020
xPaw:xpaw/send-race
Merged
Fix race condition in CMClient.Send#913azuisleet merged 1 commit intoSteamRE:masterfrom xPaw:xpaw/send-race
azuisleet merged 1 commit intoSteamRE:masterfrom
xPaw:xpaw/send-race
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My cm monitor app managed to crash there with
msg.SteamIDbeing set to null.Logged out and disconnected callback set it to null, so I assume it can race with that, although I'm not sure why.
While this isn't the most correct fix, there's no reason to access these properties twice.