Earlier assignment of seed-generation in Game:start_run#218
Closed
larswijn wants to merge 2 commits into
Closed
Conversation
Member
|
Note: playing cards are still generated after apply_to_run, and Game:start_run() relies on this ordering. There needs to be a better way for decks to modify the starting deck. |
Member
|
Deck manipulation already requires using events, and the game's seed is available when the event fires. Thus this is not needed at this time, but a better way to implement deck effects will come later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
Game:start_runfirst applies any stake and deck modifiers, and only assigns the seed afterwards. Any randomness used for any of these modifiers cannot make use of the seed of that run.By replacing the original seed generation with an empty line, and adding a hard-coded copy earlier in the function, the seed is assigned earlier and can be used by both stakes and decks when applying to the start of the run.