Skip to content

"Quantum" Enhancements#305

Merged
Aurelius7309 merged 9 commits into
mainfrom
quantum_enhancements
Dec 24, 2024
Merged

"Quantum" Enhancements#305
Aurelius7309 merged 9 commits into
mainfrom
quantum_enhancements

Conversation

@MathIsFun0
Copy link
Copy Markdown
Member

@MathIsFun0 MathIsFun0 commented Nov 28, 2024

Allows Jokers (and other effects, theoretically) to make playing cards act as if they have multiple enhancements.

Features:

  • SMODS.has_enhancement(card, key)
  • SMODS.get_enhancements(card, extra_only)
  • Works with enhancement gate checks
  • Works with vanilla jokers and most vanilla enhancements

Todo:

  • Compatibility with wild cards and similar effects
  • Full compatibility with enhancement API

@nebulazorua
Copy link
Copy Markdown
Contributor

In this same line, could be useful to have something like is_id() for quantum IDs, Incase you wanted to make, say, a Joker or Enhancement that makes a card count as multiple ranks.

@Aurelius7309
Copy link
Copy Markdown
Member

There's been discussions on the topic of quantum ranks, it's turned out quite complicated to handle straights efficiently if that is implemented, though the rank checking process would have to be normalized for other ranks as well while respecting custom ones. That's a pretty big blocker I think, but feel free to have a go at it

@nebulazorua
Copy link
Copy Markdown
Contributor

There's been discussions on the topic of quantum ranks, it's turned out quite complicated to handle straights efficiently if that is implemented, though the rank checking process would have to be normalized for other ranks as well while respecting custom ones. That's a pretty big blocker I think, but feel free to have a go at it

I see. Might give it a look some day once I have some more free time

@MathIsFun0 MathIsFun0 marked this pull request as draft December 18, 2024 04:50
@MathIsFun0
Copy link
Copy Markdown
Member Author

updated my todo list
there is also a bug with cards being saved with their "quantum" enhancements

@MathIsFun0 MathIsFun0 marked this pull request as ready for review December 23, 2024 05:27
@MathIsFun0
Copy link
Copy Markdown
Member Author

MathIsFun0 commented Dec 23, 2024

this is feature complete I think now
should be good to merge unless we want to change the way things like quantum stone and wild cards work

Copy link
Copy Markdown
Member

@Aurelius7309 Aurelius7309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for the most part, but I've noticed stone/no_suit/no_rank enhancements are unsupported as extra enhancement due to checking for just the main center. Also how should cards that have both all_suits and no_suit behave? this is relevant for poker hand evaluation

@MathIsFun0
Copy link
Copy Markdown
Member Author

wild stone cards are cursed now
image

@Aurelius7309 Aurelius7309 self-requested a review December 24, 2024 22:05
@Aurelius7309 Aurelius7309 merged commit dac6a21 into main Dec 24, 2024
@Aurelius7309 Aurelius7309 deleted the quantum_enhancements branch January 5, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants