Allow String keys in Localization Strings and Add default loc_vars function#330
Closed
Cheesy-Brik wants to merge 5 commits into
Closed
Allow String keys in Localization Strings and Add default loc_vars function#330Cheesy-Brik wants to merge 5 commits into
Cheesy-Brik wants to merge 5 commits into
Conversation
Member
|
Not needed or wanted in terms of directing new modders towards learning concepts properly, as discussed on Discord. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a default loc_vars function and allows for returned args from loc_vars to use not just number keys but also string keys. Alters the localization function directly so the string key change can be used in any text field as long as the args has that string key.
Example:
Would remove a lot of boilerplate and would probably mean most people would never have to interact with the loc_vars function
It also reads the
extratable as a fallback if the key doesn't exist.