fix repetitions ignoring remove_default_message#443
Merged
Eremel merged 1 commit intoFeb 6, 2025
Conversation
Contributor
Author
|
an example of this can be seen in the joker Forty-seven from Strange Pencil. SMODS 1404e caused it to display a duplicate Again! message, as it had assumed there was not a default message. (it displays the Again! message directly in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1404e added a default message for repetetions and joker retriggers. unfortanately, this default message is always applied, even if
remove_default_messageis specified. this pull request fixes that bug.