feat: Add permanent playing card bonuses#487
Closed
baliame wants to merge 6 commits into
Closed
Conversation
Contributor
|
@larswijn had already started working on this and was relying on me to finish the implementation for Jokers. At the very least, we had discussed some conventions for both naming and timing which might be good to go over |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code mostly based on AMM (https://github.com/AutumnMood924/AutumnMoodMechanics)
Adds most values as permanent card bonuses similar to Hiker's chip bonus. The justification here is that both my mod and Ice's Kino (https://github.com/icyethics/Kino) mod implement parts of this system. Ice planned to transition to AMM as a dependency for this, but unless I also pull in AMM as a dependency just for this feature, our Card function overrides would run twice, essentially doubling every effect. Since the demand for the feature seems high, this seems like a good candidate to support on an SMODS level.