Skip to content

Integrated card value scaling#774

Closed
the-Astra wants to merge 2 commits into
Steamodded:mainfrom
the-Astra:main
Closed

Integrated card value scaling#774
the-Astra wants to merge 2 commits into
Steamodded:mainfrom
the-Astra:main

Conversation

@the-Astra
Copy link
Copy Markdown
Contributor

@the-Astra the-Astra commented Jun 22, 2025

This PR aims to establish a dedicated function for scaling card values that allow the scalar to be affected by global values. These global values can be affected by devs who wish to change the way cards are scaling on a global level. This PR also aims to fire off a new context "context.scaling_card" to allow cards to execute functionality whenever another card scales. (I will also preface that this is my first PR to the Steamodded project so I apologize for any potentially bad practices)

Current roadblocks:

  • The timing for context.scaling_card happens before the card actually scales
  • The lovely patches that change scaling vanilla cards to use this functionality may be inefficient

Additional Info:

  • I didn't modify api's or I've made a PR to the wiki repo.
  • I didn't modify api's or I've updated lsp definitions.
  • I didn't make new lovely files or all new lovely files have appropriate priority.

@the-Astra the-Astra closed this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant