Skip to content

no_collection items in collection_pool & card_collection_UIBox#993

Closed
TheOneGoofAli wants to merge 0 commit into
Steamodded:mainfrom
TheOneGoofAli:main
Closed

no_collection items in collection_pool & card_collection_UIBox#993
TheOneGoofAli wants to merge 0 commit into
Steamodded:mainfrom
TheOneGoofAli:main

Conversation

@TheOneGoofAli
Copy link
Copy Markdown
Contributor

SMODS.card_collection_UIBox & SMODS.collection_pool now have an argument option to show/gather items that use no_collection.

Additional Info:

  • I didn't modify api's or I've made a PR to the wiki repo.
  • I didn't modify api's or I've updated lsp definitions.
  • I didn't make new lovely files or all new lovely files have appropriate priority.

@Eremel
Copy link
Copy Markdown
Member

Eremel commented Sep 29, 2025

Code looks good, but I'm not sure I understand the purpose of something like this. Do you have a specific use case in mind?

@TheOneGoofAli
Copy link
Copy Markdown
Contributor Author

Some mods may want to hide the items from the main collection pages, but not from custom-called ones could be one such use case I thought of during the initial commit.

Fulfilling the thought, perhaps additionally a no_collection-only "mode" could also be considered for those wanting to display only hidden items.

@english5040
Copy link
Copy Markdown
Collaborator

I agree with the goal, but maybe a separate function to collect stuff with ex. no_collection = true, or some other condition, would be more general.

@HuyTheKiller
Copy link
Copy Markdown
Contributor

Speaking of no_collection-only mode, I feel like we could have mods add their own hidden reason (e.g. predefined objects but locked behind dependency on another mod) as loc text.

Take a look at the following example (a streak defined as a seal in my mod):

sgt_black_streak_seal = {
    name = "Black Streak",
    text = {
        "{X:dark_edition,C:white}^^#1#{} Mult",
    },
    hidden_text = {
        "Require {C:attention}Talisman{}'s",
        "hyperoperator calculation"
    },
},

@TheOneGoofAli
Copy link
Copy Markdown
Contributor Author

...I accidentally discarded the commits on my fork as I used the "main" branch for the original PR... and I lost the original files for this, so, I may re-submit this PR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants