Fix generation failing when the target type has at least one ctor with parameters#31
Merged
StefH merged 2 commits intoStefH:mainfrom May 20, 2022
Conversation
StefH
requested changes
May 20, 2022
iam-mholle
force-pushed
the
#30_builder_generation_fails_if_target_has_ctor_with_parameters
branch
from
e3bd41b to
16c91b9
Compare
StefH
approved these changes
May 20, 2022
iam-mholle
deleted the
#30_builder_generation_fails_if_target_has_ctor_with_parameters
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30
The test generating a builder for
DateTimewas actually incorrect, asDateTimedoes have a public parameterless ctor, thus the generation should succeed. I did remove the test, but if you want I can leave it in.