Take the namespace of generated files from the RootNamespace property#50
Take the namespace of generated files from the RootNamespace property#50StefH merged 0 commit intoStefH:mainfrom
Conversation
|
@justinwritescode |
|
I wrote it on a Mac....sorry.... |
|
Ah...yes...it must be the line endings. When I click "Hide whitespace changes" it shows up fine. Sorry about that.... |
|
Can you edit this on a windows pc ? Or change the line-endings to CRLF? |
|
Actually, it looks like your line endings are inconsistent. Have a look at IFileGenerator.cs. On the left is the repo code, right is a version I just opened and saved with CRLF endings.
And here's FluentBuilderClassesGenerator.IDictionary.cs:
And here's Header.cs:
I checked some of the others I didn't touch and it looks like your files pretty much alternate CRLF and LF line endings.... Anyway, these all have consistent CRLF line endings now. If it's too confusing for you to look at, you can click the gear icon in the diff viewer and click "Hide whitespace" as shown below.
Cheers! And thanks for a great lib! |
|
I will take a look tomorrow. Thank you for investigating. |
StefH
left a comment
StefH
left a comment
There was a problem hiding this comment.
- Can you write some comments in your PR on how that "build_property.RootNamespace" should be used? (Then I will copy to this to the readme)
- And can you add a unit-test for this change? (Maybe you need a new test-project for this?)
| { | ||
| /// <see cref="Compilation.AssemblyName"/> | ||
| public string AssemblyName { get; } | ||
| public string NamespaceName { get; } |
There was a problem hiding this comment.
Can you add some comment for this new property?
|
@justinwritescode |
|
Yes but I haven't had time to implement yet... |
2 participants
Change to take the namespace from the RootNamespace property instead of from the AssemblyName. This makes the generated code configurable.