Skip to content

Fix duplicate builder members when constructor parameter matches property#77

Merged
StefH merged 7 commits intoStefH:mainfrom
WojciechNagorski:fix-76
Mar 20, 2026
Merged

Fix duplicate builder members when constructor parameter matches property#77
StefH merged 7 commits intoStefH:mainfrom
WojciechNagorski:fix-76

Conversation

@WojciechNagorski
Copy link
Copy Markdown
Contributor

@WojciechNagorski WojciechNagorski commented Mar 18, 2026

Summary

  • fix duplicate generated members when a constructor parameter and property represent the same logical member (case-insensitive match, e.g. type and Type)
  • ensure property metadata is used when de-duplicating so _isSet and assignment logic stay correct
  • generate primary-constructor invocation parameters directly from constructor symbols

Tests

  • add regression DTO for constructor-parameter/property name collision
  • add generator test to verify no duplicate _type field or WithType overloads are emitted and builder behavior remains correct

Fixes #76

@StefH
Copy link
Copy Markdown
Owner

StefH commented Mar 18, 2026

@WojciechNagorski
I think you forgot to checkin a file?
See build error...

@StefH StefH added the bug Something isn't working label Mar 18, 2026
@StefH
Copy link
Copy Markdown
Owner

StefH commented Mar 18, 2026

Can you also fix the unit tests?

Copilot AI and others added 4 commits March 20, 2026 07:33
…ated members

Co-authored-by: WojciechNagorski <17333903+WojciechNagorski@users.noreply.github.com>
…onstructor lookup

Co-authored-by: WojciechNagorski <17333903+WojciechNagorski@users.noreply.github.com>
Co-authored-by: WojciechNagorski <17333903+WojciechNagorski@users.noreply.github.com>
Fix duplicate generated members when constructor parameter name matches property name
@StefH StefH merged commit 21e06d3 into StefH:main Mar 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Builder already contains a definition

3 participants