Merged
Conversation
ailsonjr
reviewed
Jun 30, 2020
ailsonjr
left a comment
ailsonjr
left a comment
There was a problem hiding this comment.
Show de bola Stefano, ficou certinho! #vqv!
|
Boa! Muito bem documentado ! |
|
Oi Stefano, parece estar certo, mas a parte do 'shell script é demais' eu acho que não precisava do echo. Mas tô super perdida, pode ser que eu tenha feito errado |
|
Que documentação excelente! Vou me expelhar! |
|
ficou bacana, bem descrito, diferente do meu que fiz algumas linhas. =) |
|
Boa Stefano! #VQV |
|
Ótima descrição! Um bom exemplo de uma documentação completa e bem feita. |
|
Mandou bem! |
BrunoLemosCoutinho
left a comment
BrunoLemosCoutinho
left a comment
There was a problem hiding this comment.
Tudo certo, agora é só fazer o merge.
|
Muito bom. Parabéns! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a study of a pull request from week 2 day 2 at Trybe Course, here the job was to modify some random FILE from class_1_5 (Shell-Script) and create a new branch with name shell-script-changes.
After doing this new branch and changing something at the file "exercício1.sh", I've set the two commands "git add exercicio1.sh" (to prepare the file to recive a commit) and "git commit -m "Estudo do exercício Aula_2_2" (to do the changes in my local repository that I set in "exercicio1.sh" file).
The next stage was to make a command "git push -u origin shell-script-changes" to send my changes with a commit to my remote repository at github and be able to make a pull request.