Skip to content

refactor(package): use files#100

Merged
Tweentyy merged 1 commit into
developfrom
refactor/build
Apr 24, 2026
Merged

refactor(package): use files#100
Tweentyy merged 1 commit into
developfrom
refactor/build

Conversation

@Tweentyy
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 24, 2026 07:49
@Tweentyy Tweentyy merged commit f2a00af into develop Apr 24, 2026
1 check passed
@Tweentyy Tweentyy deleted the refactor/build branch April 24, 2026 07:49
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Refactors the npm package publishing configuration to explicitly control what gets published, and updates a dependency version.

Changes:

  • Add files whitelist in package.json to only publish dist/
  • Remove .npmignore (no longer needed with files)
  • Bump i18next dependency version

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
package.json Restricts published artifacts to dist/ and updates i18next version.
.npmignore Removes ignore file in favor of files whitelist.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment on lines +25 to +27
"files": [
"dist/"
],
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With files restricting the published package to dist/, the tarball will be effectively empty (or missing runtime entrypoints) if dist/ isn’t present at publish time. Ensure the publish flow guarantees dist/ exists (commonly via a prepack/prepare script that builds) so consumers don’t install a broken package.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants