Skip to content

refactor: remove unused import#104

Merged
Tweentyy merged 1 commit into
developfrom
clean
Apr 24, 2026
Merged

refactor: remove unused import#104
Tweentyy merged 1 commit into
developfrom
clean

Conversation

@Tweentyy
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 24, 2026 09:05
@Tweentyy Tweentyy merged commit 9a22b57 into develop Apr 24, 2026
1 check passed
@Tweentyy Tweentyy deleted the clean branch April 24, 2026 09:05
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Refactors the translation utility import list and bumps the package version.

Changes:

  • Removed the t named import from i18next in the translation utility.
  • Bumped package.json version from 1.7.0 to 1.7.1.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/utils/translation.ts Adjusts i18next imports, removing t.
package.json Increments package patch version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
{
"name": "@stelliajs/framework",
"version": "1.7.0",
"version": "1.7.1",
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title indicates only removing an unused import, but this PR also bumps the package version. Either update the PR title/description to mention the version bump, or move the version bump to a separate PR to keep changes scoped.

Copilot uses AI. Check for mistakes.
Comment thread src/utils/translation.ts
@@ -1,4 +1,4 @@
import { i18n, t } from "i18next";
import { i18n } from "i18next";
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i18n is only used as a TypeScript type in this file, prefer a type-only import (import type { i18n } from \"i18next\";) to avoid emitting a runtime import. If it is used at runtime, double-check that i18next actually provides a runtime named export i18n in your build setup (otherwise import the correct runtime value, e.g., the default export).

Suggested change
import { i18n } from "i18next";
import type { i18n } from "i18next";

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants