Conversation
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts build and packaging configuration to restore/build the project successfully while consolidating internal imports through index (barrel) entrypoints.
Changes:
- Updates
tsdownbuild config (clean builds, dependency bundling behavior) and removes explicit alias mappings. - Refactors several internal imports to use
@*/index.jsbarrel exports. - Updates workspace/package metadata (pnpm workspace packages, exports/types path, peer dependency changes).
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tsdown.config.ts | Tweaks build settings (clean output, dependency bundling) and removes alias mappings. |
| src/utils/logger.ts | Switches toError import to the utils barrel export. |
| src/structures/Interaction.ts | Uses structures barrel for type import. |
| src/structures/Event.ts | Uses typescript barrel for type imports. |
| src/managers/EventManager.ts | Consolidates utils imports via barrel. |
| src/client/StelliaUtils.ts | Switches logger import to utils barrel. |
| src/client/StelliaClient.ts | Switches logger import to utils barrel. |
| pnpm-workspace.yaml | Declares workspace packages and keeps allowBuilds. |
| package.json | Adjusts exports types path and moves runtime deps to peer/dev dependencies. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
package.json:32
- The exported types file was changed to
./dist/index.d.mts. Unless the build is configured to actually emitindex.d.mts(many toolchains still emitindex.d.tsby default even for ESM builds), this will cause consumers to lose types due to a missing file. Either adjust the build output to generate.d.mts, or revert the export to the actual generated declaration filename.
"exports": {
".": {
"types": "./dist/index.d.mts",
"import": "./dist/index.mjs"
},
"./package.json": "./package.json"
},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
3
to
12
| export default defineConfig({ | ||
| entry: "./src/index.ts", | ||
| platform: "node", | ||
| dts: true, | ||
| format: "esm", | ||
| alias: { | ||
| "@client": "./src/client", | ||
| "@constants": "./src/constants", | ||
| "@managers": "./src/managers", | ||
| "@structures": "./src/structures", | ||
| "@typescript": "./src/typescript", | ||
| "@utils": "./src/utils" | ||
| } | ||
| entry: "./src/index.ts", | ||
| platform: "node", | ||
| dts: true, | ||
| format: "esm", | ||
| clean: true, | ||
| deps: { | ||
| skipNodeModulesBundle: true | ||
| } | ||
| }); |
Comment on lines
+2
to
3
| import { toError } from "@utils/index.js"; | ||
|
|
Comment on lines
+38
to
+47
| "peerDependencies": { | ||
| "discord.js": "^14.26.4", | ||
| "i18next": "^26.1.0", | ||
| "i18next": "26.0.10" | ||
| }, | ||
| "dependencies": { | ||
| "log-symbols": "^7.0.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@eslint/js": "^10.0.1", | ||
| "discord.js": "^14.26.4", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.