Fix player being informed they won $0 when winning dice rolls at the Tavern#37
Merged
dmccoystephenson merged 2 commits intomainfrom Oct 13, 2025
Merged
Conversation
Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix player being informed they won $0 when winning dice rolls at the Tavern.
Fix player being informed they won $0 when winning dice rolls at the Tavern
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When players won a dice roll at the Tavern's gambling game, they were incorrectly told they won $0 instead of their actual bet amount. This happened because the code reset
self.currentBetto 0 before using it in the win message.Before the fix:
After the fix:
Solution
The fix is minimal and surgical - store the bet amount in a
winAmountvariable before resettingself.currentBetto 0. This ensures the correct amount is displayed to the player.Changes in
src/location/tavern.py:Testing
Added
test_gamble_win_shows_correct_amount()to validate the fix. All 63 tests pass successfully.Additional Changes
Minor code formatting changes from running
blackandautoflaketo maintain code style consistency.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.