Mark Object as Dirty In Drawer#2
Closed
sim2kid wants to merge 1 commit into
Closed
Conversation
The DictionaryDrawer has been given a MarkDirty method to run after the internal dictionary is modified. When the modification occurs, the serialized target object is marked as dirty, so Unity knows it needs to be reserialized/saved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DictionaryDrawerhas been given aMarkDirtymethod to run after the internal dictionary is modified. When the modification occurs, the serialized target object is marked as dirty, so Unity knows it needs to be reserialized/saved.This also adds a tracked
UnityObjectnamedtrackedObjectso that theSerializedPropertydoes not need to be passed to each method. As such, thetrackedObjectis set in theCheckInitializefunction and is cleared at the returns of theOnGUIfunctions.To mark the object as dirty, the
EditorUtility.SetDirtymethod is ran. This will mark the object as modified. Similarly, for prefab overrides, thePrefabUtility.RecordPrefabInstancePropertyModificationsis ran.See more details on these methods in the Unity Documentation.
This does explicitly not use the
Undo.RecordObjectmethod and bypasses the undo tree. It did not work when using this method instead of thew SetDirty one.This addresses issue #1.