added support for android 6#12
Merged
Stericson merged 3 commits intoStericson:masterfrom Mar 18, 2016
rahulkumar66:master
Merged
added support for android 6#12Stericson merged 3 commits intoStericson:masterfrom rahulkumar66:master
Stericson merged 3 commits intoStericson:masterfrom
rahulkumar66:master
Conversation
rahulkumar66
changed the title
Contributor
Author
|
@Stericson any chance of merging? |
Owner
|
@rattlehead666 Just curious, why not add a new method to check for ToyBox? or two methods, one that checks for both by calling the first method and a method for finding toybox? Providing this code here kinda makes the method name (description) misleading... Just interested in hearing your thoughts... |
Contributor
Author
|
I understand your concern but this way developers won't need to change anything in their code. |
Owner
|
Understood, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for checking toybox since google merged toybox into aosp since android M