Repository navigation
Replies: 19 comments
|
Good questions, and the honest answer to most of them is "after 1.8", but that deserves more than one line. What's actually happening: I've written a new engine, moved to .NET 10, and I'm mid-way through integrating the two. That work isn't in the milestone because it isn't shaped like issues yet. There are also about ten issues I want in 1.8 and some PRs to merge. So the milestone looking like a triaged community inbox is accurate, it just isn't the whole picture, and that's on me rather than on you for not being able to see it. On the list: I assign myself to what I'm working on or have already fixed, so the milestone is a real list, just an incomplete one. If you want something, ask and I'll assign it. One condition: be quick. I don't want to be holding a release open waiting on a PR. On print: it's in good shape and I have nothing planned for it, so there's no gap there for you to fill. I'd rather point you at the older issues nobody has picked up. Nothing to do with your work on it, there just isn't a problem to solve right now. On the unwritten rules: fair hit, that one cost you time and shouldn't have. The reason for Auto is that the options column is a fixed 260px, so a reserved scrollbar spends 17 of them permanently on a panel that usually fits. Your version fixes the reflow when the bar appears; I'd rather have the width. That's a judgement call and you had no way to see it from outside. Constraints in that dialog, since you asked: the options column is fixed at 260px, the dialog has a MinWidth of 720, and the gutter between the settings column and the preview frame is deliberate. More generally, I'll take theme-correctness and layout fixes readily, and I'm slow on anything that adds a dependency. I should have said all that on the PR instead of quietly changing the line. On where to post: discussions for this, issues for bugs, exactly as you've been doing. It's working. None of this is a brush-off. It's that I'm holding a half-finished engine swap in my head and I'm bad company until it's done. Ask me again when 1.8 is out and I'll have a proper answer about where you can own something. Steve |
|
I'll probably push out an alpha into the repo soon. then we'll have time to work on the remaining issues and PRs, then when we decide all the features and PRs and fixes are in, I'll pull it all back and finish everything up, and then build out the full release. and then wait for all the new bug reports to roll in... But at the pace I'm going, we may skip the 1.9.x branch entirely and start work on the cross-platform 2.0 release. 2.0 has to be the real Acrobat killer and I want that GitHub issues list empty by then, lol. |
|
Had to use Acrobat for something the other day, first time in a while, and it did my head in after being on this. So 2.0 as the real Acrobat killer gets no argument from me, that's the right thing to aim at. Appreciate you laying all that out, print included. All taken on board. I've been happy enough picking up whatever comes through that I feel comfortable working on, or just commenting where I can, so I'll keep doing that. Sing out if there's something specific you want taken. No rush on any of it, go and get the engine swap done. Matt |
|
Alpha 2 repo is on the dev branch. I've made a lot of commits so please test them out, and anything new you need added please start pushing PRs |
|
Beta.2 is out, I'm reviewing all 6 of your PRs now and they look good! I've split the release into two now: portable and installed. Let me know your thoughts. |
|
I just pushed out Beta.3 before going to hit the hay. |
|
That's me for the day. Left you #258 for the other half of #246, and #259 with three things in the portable launcher. Those three are read off the code rather than reproduced, so treat them as leads rather than confirmed. The installer and the portable/installed split are the one thing of yours I haven't got to. I'll pick that up tomorrow if there's still something you want tested by then. Reckon it's getting late your end. No rush on any of it. |
|
Hey Matt, I just pushed the beta.4 work to The main things I’d like checked are:
Cross-document dragging should copy the pages into the destination without changing the source, and it should carry unsaved annotations with them. There are also several smaller fixes and the new KillerPDF.Engine documentation in this push. |
|
Went through your list on beta.5, built off Cross-document dragging works. Pages land where the line says they will and the source document is untouched - I checked that at the file level rather than by eye, the source PDF is byte identical after the copy. Annotations ride along: highlighted a page, dragged it across without saving, and the highlight arrived on the copy and stayed on the original as well. The insertion line draws at the top of the page from the upper half and the bottom from the lower half. Fullscreen is exact on both my monitors including a portrait secondary, no overhang on any edge, and it restores to the original size. Wheel scrolling is back. Sidebar thumbnails follow the focused pane. One thing did not pass. The total above the thumbnails keeps whichever document rendered last, so a four page document sits under a Two gaps, so you are not assuming coverage I do not have:
Your beta.4 fixes for #259 all check out. I reproduced the first one properly this time rather than reading it off the code, held a lock across the whole retry window, and it swallows the failure and leaves the directory for the sweep. No rush on any of it. |
|
Beta.5 is pushed now, and I merged #265. Thanks again for catching the sidebar count issue and for testing the rest of that list so thoroughly. I also took your #266 report seriously and rebuilt the document undo path instead of leaving it for 1.9. Document changes now enter undo history automatically, including page deletion, insertion, reordering, cross-pane copying, forms, links, metadata, bookmarks, crop, and rotation. Undo and redo also restore annotations and page rotations. The history is capped at 20 actions and 256 MB per document so it can't grow forever with large PDFs. When you get a chance, the main things left to beat on are:
No rush. You've already cleared a huge amount of uncertainty around this release, and I really appreciate it. |
|
No stress mate. I hit the same thing on a project a couple of months back. I'll chip away at a few off that list. |
|
Hey Matt! I pushed a pretty substantial round of KillerPDF installer improvements to Whenever you have time, I’d love for you to test it and see if you can find anything I missed. |
|
Worked through the rest of the list. Built a Windows 10 VM for the installer items. Undo and redo hold up across a mixed sequence: delete a page, move one down, move another up, delete the first, then four undos back to the start and four redos out again. Every intermediate state matched, checked against the working file each step and not by eye. Closing and reopening a document clears the history properly too, so the pre-close version doesn't come back. Save, Save As and reopen are clean. Save As left the original byte identical, the reopened copy loaded in the same order, and a save in place after a delete rewrote the file correctly. All of it read back from the bytes. Unicode form saves went on #256. A correction on the installer. My last report said the runtime check and the download prompt were wired right. I read that off the code and never ran it. They are, on the wizard and on The portable handoff turned up two more, both up as PRs: #277 for a #238 doesn't reproduce. The momentary second task is real on both install paths, but there's no error beside it now, and the flow the reporter described has no path left. I've said that to him on the issue. Two things I couldn't cover. The installer tests ran with UAC off in the guest, since that's the only way the automation gets an elevated process, so anything needing a consent prompt in the path is untested. And I haven't tried winget. |
|
No worries, and thanks again for all the testing. I merged #277. I’ll take care of the fixes for #275 and #279 myself while you’re busy. #278 is still there whenever you’re back, but there’s no rush. I only want to move its new user-facing messages into the localization resources before merging it. Nothing is waiting on you. Go handle your other work and I’ll keep things moving here. Most of these issues are just packaging problems so it's getting real close. |
|
Looks like we actually made it to the end of the list. This release is in a much better place because of your help. I can't believe how far this app has come. |
|
Yeah mate, you're having a proper crack at this. You're putting a fair few hours in and that much is obvious from out here. |
|
Kazakh is done. Code is frozen. I'll take screenshots after release, I'm not too worried about those yet because the current shots are pretty good. I think we can release this today! |
|
And just like that... it's over. Time for a new thread I guess! |
Uh oh!
There was an error while loading. Please reload this page.
Steve - four questions, no rush on any of them.
Autoback on the print options scroller after merging Reserve the print options scrollbar, unbox the combo and picker chevrons #219. I couldn't see the constraint from outside, and undoing it cost you time. Two or three lines on what you'd reject on sight would save us both that: layout constraints, dependencies you won't take, patterns you've already tried and binned.Posted here rather than the tracker since it isn't a bug. Happy to keep using Discussions for anything like this, so your issues stay actual issues.
If the answer to all four is "after 1.8 ships", that's a fine answer.
Matt
All reactions