fix: handle array-to-array comparison in filter matching #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I noticed the current filter logic doesn't handle comparing arrays properly. Simple example: If you have ['tags' => ['red', 'blue']] as a filter and a record with the same tags array, it'll now match as expected. Before this fix, it would always return false since in_array() can't compare arrays. |
Owner
|
@frans-slabbekoorn thanks for the PR! Could you add some tests? |
Author
|
@Sti3bas I have added the tests you requested, please let me know if you have feedback! |
Author
|
Closed in favor of #27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.