Compute Dominance levels from input data#152
Merged
Merged
Conversation
…hard coded - Levels of the 'Dominance' column are now derived from the input data frames `sim` and `obs`. - If 'Dominance' is absent or contains NA values, these are replaced by the hard-coded value "Single Crop".
Add conditional checks in `format_cropr` so `sim$Dominance`, `obs$Dominance`, and `obs_sd$Dominance` are only converted to factors if not already. This ensures existing factor levels and their order are preserved, preventing unnecessary warnings and unintended changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates CroPlotR to handle the 'Dominance' column from input data instead of using hard-coded levels.
Changes
simandobs."Single Crop".Benefits