[codex] Route OpenCode missing-session errors through Effect#22
Open
StiensWout wants to merge 1 commit into
Open
[codex] Route OpenCode missing-session errors through Effect#22StiensWout wants to merge 1 commit into
StiensWout wants to merge 1 commit into
Conversation
Co-authored-by: Codex <codex@openai.com>
Owner
Author
|
@codex please review this PR. |
github-actions
Bot
added
vouch:trusted
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendTurnandstopSession.Root cause
OpenCodeAdapter checked session state with a synchronous helper inside Effect bodies, so missing sessions were thrown as defects instead of returned through the typed provider adapter error channel.
Impact
Missing or already-stopped OpenCode sessions now fail predictably through typed adapter errors.
stopSessionstill uses its direct session lookup and preserves the existing cleanup behavior for stopped contexts.Validation
PATH="$HOME/.vite-plus/bin:$PATH" vp test apps/server/src/provider/Layers/OpenCodeAdapter.test.tsPATH="$HOME/.vite-plus/bin:$PATH" vp checkPATH="$HOME/.vite-plus/bin:$PATH" vp run typecheck