Implemented a customizable ModuleBuilderProvider#122
Merged
MattEdwardsWaggleBee merged 4 commits intoStillpoint-Software:mainfrom Feb 4, 2026
Conversation
…ding the default behavior. This allows using a collectable assembly builder which makes the expressions compatible with types from collectible assemblies
…e clear what it does
MattEdwardsWaggleBee
approved these changes
Feb 4, 2026
b344901
into
Stillpoint-Software:main
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To get this library to work for our use case we need to use an expression with types coming from collectible-assemblies.
This PR provides a solution to this feature:
The implementation of this PR allows to pass an
ExpressionRuntimeOptionsobject. For now, it contains a single property namedModuleBuilderProviderwhich can be used to switch to a differentIModuleBuilderProviderimplementation. Out of the box, it ships with theDefaultModuleBuilderProviderwhich has the same behavior as before, and is therefore the default implementation. When requried, one can switch to theCollectibleModuleBuilderProviderwhich configures the assembly builder withAssemblyBuilderAccess.RunAndColect. This will be what we'll be choosing for our current use cases. For advanced scenario's the property can also be assigned to a custom implementation ofIModuleBuilderProvider.This implementation is how we would fix this issue, does this allign with your idea's about this library? I'll add some documentation if you're satisfied with this PR.
Type of Change
Checklist