Skip to content

Implemented a customizable ModuleBuilderProvider#122

Merged
MattEdwardsWaggleBee merged 4 commits intoStillpoint-Software:mainfrom
victorr99:feature/121-configurable-assembly-builder-access
Feb 4, 2026
Merged

Implemented a customizable ModuleBuilderProvider#122
MattEdwardsWaggleBee merged 4 commits intoStillpoint-Software:mainfrom
victorr99:feature/121-configurable-assembly-builder-access

Conversation

@victorr99
Copy link
Copy Markdown
Contributor

Description

To get this library to work for our use case we need to use an expression with types coming from collectible-assemblies.

This PR provides a solution to this feature:

The implementation of this PR allows to pass an ExpressionRuntimeOptions object. For now, it contains a single property named ModuleBuilderProvider which can be used to switch to a different IModuleBuilderProvider implementation. Out of the box, it ships with the DefaultModuleBuilderProvider which has the same behavior as before, and is therefore the default implementation. When requried, one can switch to the CollectibleModuleBuilderProvider which configures the assembly builder with AssemblyBuilderAccess.RunAndColect. This will be what we'll be choosing for our current use cases. For advanced scenario's the property can also be assigned to a custom implementation of IModuleBuilderProvider.

This implementation is how we would fix this issue, does this allign with your idea's about this library? I'll add some documentation if you're satisfied with this PR.

Type of Change

  • Bug fix
  • New feature
  • Documentation

Checklist

  • I have run the existing tests and they pass
  • I have run the existing benchmarks and verified performance has not decreased
  • I have added new tests that prove my change is effective or that my feature works
  • I have added the necessary documentation (if applicable)

…ding the default behavior. This allows using a collectable assembly builder which makes the expressions compatible with types from collectible assemblies
@MattEdwardsWaggleBee MattEdwardsWaggleBee merged commit b344901 into Stillpoint-Software:main Feb 4, 2026
5 checks passed
@victorr99 victorr99 deleted the feature/121-configurable-assembly-builder-access branch February 5, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants