fix test_lightcurve fails #886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stingray/tests/test_lightcurve.py
Outdated
| assert_allclose(lk.flux, counts) | ||
| assert_allclose(lk.flux_err, counts_err) | ||
| with warnings.catch_warnings(): | ||
| warnings.filterwarnings("ignore", category=DeprecationWarning) |
Contributor
There was a problem hiding this comment.
Please also mention that what Warning message we are getting.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #886 +/- ##
===========================================
- Coverage 96.03% 46.50% -49.53%
===========================================
Files 48 48
Lines 9770 9768 -2
===========================================
- Hits 9383 4543 -4840
- Misses 387 5225 +4838 ☔ View full report in Codecov by Sentry. |
Member
|
@aDNAn-itis there is a better way to ignore warnings from tests. There is a dedicated section in the pyproject.toml |
…/stingray into test_lightcurve-fails
Contributor
Author
|
@matteobachetti done! |
matteobachetti
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suppress deprecation warnings
#882 (comment)
fixes #882