Skip to content

Pause-resume patch fixes #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
briandrawert merged 3 commits into from
Jan 18, 2022
Merged

Pause-resume patch fixes #684

briandrawert merged 3 commits into from
Jan 18, 2022

Conversation

@jtcooper10
Copy link
Collaborator

@jtcooper10 jtcooper10 commented Jan 14, 2022

Temporary fixes for pause-resume behavior in C++ solvers.

Fixes

  • Fixed repeated output on pause-resume, caused by identical seeds between runs
    • Uses simulation process id as part of seed
    • Note: getpid() is deprecated on Windows, so getting the process id is platform-specific
  • Fixed rounding issue for variable solvers by passing command-line args as floats rather than ints

@jtcooper10
Bug fixes for pause-resume
1ef7594 
- Changed `--init_pop` to accept `float` rather than `int` to remove rounding on startup
- Use `getpid()` as a temporary fix for RNG seed
@jtcooper10
Add C++ includes/macros for getpid(), port getpid() seed to other…
0fe86fc 
… solvers
@jtcooper10 jtcooper10 added this to the 1.6.8 milestone Jan 14, 2022
@jtcooper10 jtcooper10 mentioned this pull request Jan 15, 2022
Closed
@jtcooper10 jtcooper10 linked an issue Jan 15, 2022 that may be closed by this pull request
C++ solvers: simultaneous (or near-simultaneous) runs have identical output #685
Closed
@jtcooper10 jtcooper10 removed a link to an issue Jan 15, 2022
C++ solvers: simultaneous (or near-simultaneous) runs have identical output #685
Closed
@briandrawert briandrawert merged commit fbb02f8 into develop Jan 18, 2022
@briandrawert briandrawert deleted the fix/pause-resume-rounding branch January 18, 2022 02:12
@seanebum seanebum mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandrawert briandrawert briandrawert approved these changes

@BryanRumsey BryanRumsey BryanRumsey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.6.8

Development

Successfully merging this pull request may close these issues.

4 participants

@jtcooper10 @briandrawert @BryanRumsey